[PATCH] D54995: [MemoryBuffer] Add the setter to be able to force disabled mmap

Zachary Turner via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 3 07:42:28 PST 2018


I don’t think we really need this. isn’t Ilya’s solution in the other patch
already sufficient?
On Mon, Dec 3, 2018 at 7:34 AM Ivan Donchevskii via Phabricator <
reviews at reviews.llvm.org> wrote:

> yvvan added a comment.
>
> @ilya-biryukov
>
> Hm. What about another way around? - We have user include paths (-I) and
> report them to the filesystem. This means that we have specific paths under
> which nothing can be mmaped and everything else can be. In particular cases
> we can also report -isystem there. This is quite the same logic as current
> isVolatile parameter but is set only once for each path.
>
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D54995/new/
>
> https://reviews.llvm.org/D54995
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20181203/009371a8/attachment.html>


More information about the cfe-commits mailing list