r348123 - [clang] Do not read from 'test/SemaCXX/Inputs' inside 'test/AST'

[Ilya Biryukov via cfe-commits]

No worries, this was easy to fix.
It's impossible to catch those in advance, we miss things like that all the
time.

On Mon, Dec 3, 2018 at 1:19 PM Aaron Ballman <aaron at aaronballman.com> wrote:

> On Mon, Dec 3, 2018 at 6:29 AM Ilya Biryukov via cfe-commits
> <cfe-commits at lists.llvm.org> wrote:
> >
> > Author: ibiryukov
> > Date: Mon Dec  3 03:26:35 2018
> > New Revision: 348123
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=348123&view=rev
> > Log:
> > [clang] Do not read from 'test/SemaCXX/Inputs' inside 'test/AST'
> >
> > Our integrate relies on test inputs being taken from the same diretory
> as the
> > test itself.
>
> Sorry about that! I was trying to avoid duplicating the same header
> file in two different places and didn't realize this would cause an
> issue.
>
> ~Aaron
>
> >
> > Added:
> >     cfe/trunk/test/AST/Inputs/std-coroutine.h
> > Modified:
> >     cfe/trunk/test/AST/coroutine-source-location-crash.cpp
> >
> > Added: cfe/trunk/test/AST/Inputs/std-coroutine.h
> > URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/AST/Inputs/std-coroutine.h?rev=348123&view=auto
> >
> ==============================================================================
> > --- cfe/trunk/test/AST/Inputs/std-coroutine.h (added)
> > +++ cfe/trunk/test/AST/Inputs/std-coroutine.h Mon Dec  3 03:26:35 2018
> > @@ -0,0 +1,37 @@
> > +// RUN: %clang_cc1 -triple x86_64-apple-darwin9 %s -std=c++14
> -fcoroutines-ts -fsyntax-only -Wignored-qualifiers -Wno-error=return-type
> -verify -fblocks -Wno-unreachable-code -Wno-unused-value
> > +#ifndef STD_COROUTINE_H
> > +#define STD_COROUTINE_H
> > +
> > +namespace std {
> > +namespace experimental {
> > +
> > +template <class Ret, typename... T>
> > +struct coroutine_traits { using promise_type = typename
> Ret::promise_type; };
> > +
> > +template <class Promise = void>
> > +struct coroutine_handle {
> > +  static coroutine_handle from_address(void *);
> > +};
> > +template <>
> > +struct coroutine_handle<void> {
> > +  template <class PromiseType>
> > +  coroutine_handle(coroutine_handle<PromiseType>);
> > +  static coroutine_handle from_address(void *);
> > +};
> > +
> > +struct suspend_always {
> > +  bool await_ready() { return false; }
> > +  void await_suspend(coroutine_handle<>) {}
> > +  void await_resume() {}
> > +};
> > +
> > +struct suspend_never {
> > +  bool await_ready() { return true; }
> > +  void await_suspend(coroutine_handle<>) {}
> > +  void await_resume() {}
> > +};
> > +
> > +} // namespace experimental
> > +} // namespace std
> > +
> > +#endif // STD_COROUTINE_H
> >
> > Modified: cfe/trunk/test/AST/coroutine-source-location-crash.cpp
> > URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/AST/coroutine-source-location-crash.cpp?rev=348123&r1=348122&r2=348123&view=diff
> >
> ==============================================================================
> > --- cfe/trunk/test/AST/coroutine-source-location-crash.cpp (original)
> > +++ cfe/trunk/test/AST/coroutine-source-location-crash.cpp Mon Dec  3
> 03:26:35 2018
> > @@ -1,6 +1,6 @@
> >  // RUN: %clang_cc1 -triple x86_64-apple-darwin9 %s -std=c++14
> -fcoroutines-ts \
> >  // RUN:    -fsyntax-only -ast-dump | FileCheck %s
> > -#include "../SemaCXX/Inputs/std-coroutine.h"
> > +#include "Inputs/std-coroutine.h"
> >
> >  using namespace std::experimental;
> >
> >
> >
> > _______________________________________________
> > cfe-commits mailing list
> > cfe-commits at lists.llvm.org
> > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>


-- 
Regards,
Ilya Biryukov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20181203/0f9ffe51/attachment-0001.html>