<div dir="ltr">No worries, this was easy to fix.<div>It's impossible to catch those in advance, we miss things like that all the time.</div></div><br><div class="gmail_quote"><div dir="ltr">On Mon, Dec 3, 2018 at 1:19 PM Aaron Ballman <<a href="mailto:aaron@aaronballman.com">aaron@aaronballman.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Mon, Dec 3, 2018 at 6:29 AM Ilya Biryukov via cfe-commits<br>
<<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>> wrote:<br>
><br>
> Author: ibiryukov<br>
> Date: Mon Dec  3 03:26:35 2018<br>
> New Revision: 348123<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=348123&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=348123&view=rev</a><br>
> Log:<br>
> [clang] Do not read from 'test/SemaCXX/Inputs' inside 'test/AST'<br>
><br>
> Our integrate relies on test inputs being taken from the same diretory as the<br>
> test itself.<br>
<br>
Sorry about that! I was trying to avoid duplicating the same header<br>
file in two different places and didn't realize this would cause an<br>
issue.<br>
<br>
~Aaron<br>
<br>
><br>
> Added:<br>
>     cfe/trunk/test/AST/Inputs/std-coroutine.h<br>
> Modified:<br>
>     cfe/trunk/test/AST/coroutine-source-location-crash.cpp<br>
><br>
> Added: cfe/trunk/test/AST/Inputs/std-coroutine.h<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/AST/Inputs/std-coroutine.h?rev=348123&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/AST/Inputs/std-coroutine.h?rev=348123&view=auto</a><br>
> ==============================================================================<br>
> --- cfe/trunk/test/AST/Inputs/std-coroutine.h (added)<br>
> +++ cfe/trunk/test/AST/Inputs/std-coroutine.h Mon Dec  3 03:26:35 2018<br>
> @@ -0,0 +1,37 @@<br>
> +// RUN: %clang_cc1 -triple x86_64-apple-darwin9 %s -std=c++14 -fcoroutines-ts -fsyntax-only -Wignored-qualifiers -Wno-error=return-type -verify -fblocks -Wno-unreachable-code -Wno-unused-value<br>
> +#ifndef STD_COROUTINE_H<br>
> +#define STD_COROUTINE_H<br>
> +<br>
> +namespace std {<br>
> +namespace experimental {<br>
> +<br>
> +template <class Ret, typename... T><br>
> +struct coroutine_traits { using promise_type = typename Ret::promise_type; };<br>
> +<br>
> +template <class Promise = void><br>
> +struct coroutine_handle {<br>
> +  static coroutine_handle from_address(void *);<br>
> +};<br>
> +template <><br>
> +struct coroutine_handle<void> {<br>
> +  template <class PromiseType><br>
> +  coroutine_handle(coroutine_handle<PromiseType>);<br>
> +  static coroutine_handle from_address(void *);<br>
> +};<br>
> +<br>
> +struct suspend_always {<br>
> +  bool await_ready() { return false; }<br>
> +  void await_suspend(coroutine_handle<>) {}<br>
> +  void await_resume() {}<br>
> +};<br>
> +<br>
> +struct suspend_never {<br>
> +  bool await_ready() { return true; }<br>
> +  void await_suspend(coroutine_handle<>) {}<br>
> +  void await_resume() {}<br>
> +};<br>
> +<br>
> +} // namespace experimental<br>
> +} // namespace std<br>
> +<br>
> +#endif // STD_COROUTINE_H<br>
><br>
> Modified: cfe/trunk/test/AST/coroutine-source-location-crash.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/AST/coroutine-source-location-crash.cpp?rev=348123&r1=348122&r2=348123&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/AST/coroutine-source-location-crash.cpp?rev=348123&r1=348122&r2=348123&view=diff</a><br>
> ==============================================================================<br>
> --- cfe/trunk/test/AST/coroutine-source-location-crash.cpp (original)<br>
> +++ cfe/trunk/test/AST/coroutine-source-location-crash.cpp Mon Dec  3 03:26:35 2018<br>
> @@ -1,6 +1,6 @@<br>
>  // RUN: %clang_cc1 -triple x86_64-apple-darwin9 %s -std=c++14 -fcoroutines-ts \<br>
>  // RUN:    -fsyntax-only -ast-dump | FileCheck %s<br>
> -#include "../SemaCXX/Inputs/std-coroutine.h"<br>
> +#include "Inputs/std-coroutine.h"<br>
><br>
>  using namespace std::experimental;<br>
><br>
><br>
><br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Regards,</div><div>Ilya Biryukov</div></div></div></div></div>