[PATCH] D55188: Extract TextChildDumper class

Mon Dec 3 06:16:37 PST 2018

aaron.ballman added inline comments.

================
Comment at: include/clang/AST/ASTDumperUtils.h:22
+
+namespace ast_dumper {
+// Colors used for various parts of the AST dump
----------------
steveire wrote:
> aaron.ballman wrote:
> > I'm not certain this namespace is useful, especially when it gets imported at TU scope in ASTDumper.cpp.
> > it gets imported at TU scope in ASTDumper.cpp
> 
> Today that's the only place it is used. In the future that won't be true.
Then we can add the namespace in the future when we find a situation where we're worried about collisions? As it stands, this only provides the illusion of safety. If you really want to keep it, please pull the global using declaration.

Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55188/new/

https://reviews.llvm.org/D55188