[PATCH] D55188: Extract TextChildDumper class

Stephen Kelly via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 3 06:08:32 PST 2018


steveire marked an inline comment as done.
steveire added inline comments.


================
Comment at: include/clang/AST/ASTDumperUtils.h:22
+
+namespace ast_dumper {
+// Colors used for various parts of the AST dump
----------------
aaron.ballman wrote:
> I'm not certain this namespace is useful, especially when it gets imported at TU scope in ASTDumper.cpp.
> it gets imported at TU scope in ASTDumper.cpp

Today that's the only place it is used. In the future that won't be true.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55188/new/

https://reviews.llvm.org/D55188





More information about the cfe-commits mailing list