[PATCH] D55023: OpenCL: Improve vector printf warnings

[Matt Arsenault via Phabricator via cfe-commits]

arsenm marked 2 inline comments as done.
arsenm added inline comments.


================
Comment at: test/SemaOpenCL/format-strings-fixit.cl:13
+void vector_fixits() {
+//  printf("%f", (int) 123);
+  printf("%v4f", (int4) 123);
----------------
Anastasia wrote:
> Does this not work yet?
It does. This was a leftover reference I was using I can remove


================
Comment at: test/SemaOpenCL/printf-format-strings.cl:65
+{
+    printf("%v4f\n", arg); // expected-warning {{format specifies type 'double __attribute__((ext_vector_type(4)))' but the argument has type 'float2' (vector of 2 'float' values)}}
 }
----------------
Anastasia wrote:
> So there is no way to print vector of float? What will happen on architectures that don't support doubles?
> 
> I guess it's the same for printf in general with the float type?
There is, it's converted to a vector of doubles. This case warns because the element count mismatches


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55023/new/

https://reviews.llvm.org/D55023