[PATCH] D55023: OpenCL: Improve vector printf warnings

Anastasia Stulova via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 29 03:23:24 PST 2018


Anastasia added inline comments.


================
Comment at: test/SemaOpenCL/format-strings-fixit.cl:13
+void vector_fixits() {
+//  printf("%f", (int) 123);
+  printf("%v4f", (int4) 123);
----------------
Does this not work yet?


================
Comment at: test/SemaOpenCL/printf-format-strings.cl:65
+{
+    printf("%v4f\n", arg); // expected-warning {{format specifies type 'double __attribute__((ext_vector_type(4)))' but the argument has type 'float2' (vector of 2 'float' values)}}
 }
----------------
So there is no way to print vector of float? What will happen on architectures that don't support doubles?

I guess it's the same for printf in general with the float type?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55023/new/

https://reviews.llvm.org/D55023





More information about the cfe-commits mailing list