[PATCH] D54878: [clangd] NFC: Prefer `isa<>` to `dyn_cast<>` to do the checking.

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 26 06:38:12 PST 2018


ilya-biryukov added a comment.

In D54878#1307845 <https://reviews.llvm.org/D54878#1307845>, @MTC wrote:

> We can land this change this time or do the cleaning job in other patches in the future, it's all up to you guys, the active clangd contributors :).


Please land this, it's a useful cleanup.
Unless you'd prefer to not spend any more time on this, in which case I'd just land it for you :-)


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54878/new/

https://reviews.llvm.org/D54878





More information about the cfe-commits mailing list