[PATCH] D54878: [clangd] NFC: Prefer `isa<>` to `dyn_cast<>` to do the checking.

Henry Wong via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 26 05:51:19 PST 2018


MTC added a comment.

In D54878#1307726 <https://reviews.llvm.org/D54878#1307726>, @ilya-biryukov wrote:

> But given that `isa<>` are still better than `dyn_cast<>`, this change might still be worth landing.


We can land this change this time or do the cleaning job in other patches in the future, it's all up to you guys, the active clangd contributors.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54878/new/

https://reviews.llvm.org/D54878





More information about the cfe-commits mailing list