[PATCH] D53697: [ASTImporter][Structural Eq] Check for isBeingDefined

[Gabor Marton via Phabricator via cfe-commits]

martong added a comment.
Herald added a subscriber: gamesh411.

@shafik,

I could run the libcxx tests on my Linux machine (Ubuntu 16.04) by installing libcxx: `sudo apt-get install libc++-dev`.
>From the logs of your build server seems like the crash happened with a `_gmodules` test.
Unfortunately, the gmodules tests are still skipped on Linux:

  Collected 8 tests
  
  1: test_ref_and_ptr_dsym (TestDataFormatterLibcxxVector.LibcxxVectorDataFormatterTestCase)
     Test that that file and class static variables display correctly. ... skipped 'test case does not fall in any category of interest for this run'
  2: test_ref_and_ptr_dwarf (TestDataFormatterLibcxxVector.LibcxxVectorDataFormatterTestCase)
     Test that that file and class static variables display correctly. ... ok
  3: test_ref_and_ptr_dwo (TestDataFormatterLibcxxVector.LibcxxVectorDataFormatterTestCase)
     Test that that file and class static variables display correctly. ... ok
  4: test_ref_and_ptr_gmodules (TestDataFormatterLibcxxVector.LibcxxVectorDataFormatterTestCase)
     Test that that file and class static variables display correctly. ... skipped 'test case does not fall in any category of interest for this run'
  5: test_with_run_command_dsym (TestDataFormatterLibcxxVector.LibcxxVectorDataFormatterTestCase)
     Test that that file and class static variables display correctly. ... skipped 'test case does not fall in any category of interest for this run'
  6: test_with_run_command_dwarf (TestDataFormatterLibcxxVector.LibcxxVectorDataFormatterTestCase)
     Test that that file and class static variables display correctly. ... ok
  7: test_with_run_command_dwo (TestDataFormatterLibcxxVector.LibcxxVectorDataFormatterTestCase)
     Test that that file and class static variables display correctly. ... ok
  8: test_with_run_command_gmodules (TestDataFormatterLibcxxVector.LibcxxVectorDataFormatterTestCase)
     Test that that file and class static variables display correctly. ... skipped 'test case does not fall in any category of interest for this run'
  
  ----------------------------------------------------------------------
  Ran 8 tests in 1.260s

This  is aligned with the content of `test_categories.py`:

  def is_supported_on_platform(category, platform, compiler_path):
      if category == "dwo":
          # -gsplit-dwarf is not implemented by clang on Windows.
          return platform in ["linux", "freebsd"]
      elif category == "dsym":
          return platform in ["darwin", "macosx", "ios", "watchos", "tvos", "bridgeos"]
      elif category == "gmodules":
          # First, check to see if the platform can even support gmodules.
          if platform not in ["freebsd", "darwin", "macosx", "ios", "watchos", "tvos", "bridgeos"]:
              return False
          return gmodules.is_compiler_clang_with_gmodules(compiler_path)
      return True

So apparently I cannot run `gmodules` tests on Linux.

My next step is trying to reproduce the issue on a real MacOS laptop.


Repository:
  rC Clang

https://reviews.llvm.org/D53697