[PATCH] D54630: Move detection of libc++ include dirs to Driver on MacOS

Louis Dionne via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 16 11:19:50 PST 2018


ldionne added a comment.

In https://reviews.llvm.org/D54630#1301283, @arphaman wrote:

> I don't think we want to move the logic to add a libc++ path to the driver.


My opinion is not very educated because I don't have a lot of experience/knowledge of Clang, but from my perspective it does make sense to limit how much knowledge of the standard library path the front end needs to have. IOW, having the driver figure it out and then pass include paths to the front-end just like for any other library does make sense from my limited point of view. Again -- this is not a practical argument, it's just from a conceptual perspective.


Repository:
  rC Clang

https://reviews.llvm.org/D54630





More information about the cfe-commits mailing list