[PATCH] D54630: Move detection of libc++ include dirs to Driver on MacOS

Alex Lorenz via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 16 10:27:11 PST 2018


arphaman added a comment.

I don't think we want to move the logic to add a libc++ path to the driver. `-cc1` with `-resource-dir` and `-stdlib=libc++` should still work as before. In this case the previous patch is better, except it should not set `InstalledDir` except when needed (e.g. for tooling when working with a CDB that has an absolute path to the compiler), so when `InstalledDir` is empty it should fallback to the current logic in `InitHeaderSearch.cpp`. That should solve the issues we had.


Repository:
  rC Clang

https://reviews.llvm.org/D54630





More information about the cfe-commits mailing list