[PATCH] D54425: [AArch64] Add aarch64_vector_pcs function attribute to Clang

[Sander de Smalen via Phabricator via cfe-commits]

sdesmalen marked an inline comment as done.
sdesmalen added inline comments.


================
Comment at: include/clang/Basic/Attr.td:1792
+  let Spellings = [GNU<"aarch64_vector_pcs">,
+                   CXX11<"clang", "aarch64_vector_pcs">,
+                   Keyword<"__aarch64_vector_pcs">,
----------------
aaron.ballman wrote:
> Rather than using GNU and CXX11 spellings, you should use the Clang spelling. If the attribute is not useful in C, then set `allowInC` to 0 instead of its default of 1.
Thanks for the suggestion! The attribute is valid in C as well, and is tested for both C and C++ in test/CodeGen/aarch64-vpcs.c.


================
Comment at: include/clang/Basic/Attr.td:1794
+                   Keyword<"__aarch64_vector_pcs">,
+                   Keyword<"_aarch64_vector_pcs">];
+  let Documentation = [AArch64VectorPcsDocs];
----------------
aaron.ballman wrote:
> This steps on the user's namespace -- is that intended and necessary?
That was not intended and looking at the spec, the keyword is not required so I'll remove it.


https://reviews.llvm.org/D54425