[PATCH] D54425: [AArch64] Add aarch64_vector_pcs function attribute to Clang

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added inline comments.


================
Comment at: include/clang/Basic/Attr.td:1792
+  let Spellings = [GNU<"aarch64_vector_pcs">,
+                   CXX11<"clang", "aarch64_vector_pcs">,
+                   Keyword<"__aarch64_vector_pcs">,
----------------
Rather than using GNU and CXX11 spellings, you should use the Clang spelling. If the attribute is not useful in C, then set `allowInC` to 0 instead of its default of 1.


================
Comment at: include/clang/Basic/Attr.td:1794
+                   Keyword<"__aarch64_vector_pcs">,
+                   Keyword<"_aarch64_vector_pcs">];
+  let Documentation = [AArch64VectorPcsDocs];
----------------
This steps on the user's namespace -- is that intended and necessary?


================
Comment at: include/clang/Basic/AttrDocs.td:1748
+  let Content = [{
+On 64 bit ARM targets, this argument causes the function to obey the vector
+procedural call standard (VPCS) rules as described in the Vector ABI for
----------------
64 bit -> 64-bit


https://reviews.llvm.org/D54425