[PATCH] D54166: [AST] Store the string data in StringLiteral in a trailing array of chars
David Blaikie via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Nov 12 15:39:34 PST 2018
dblaikie added a comment.
In https://reviews.llvm.org/D54166#1295730, @riccibruno wrote:
> @dblaikie Thanks for looking at this patch !
>
> I have a set of patches shrinking the other statements/expressions.
> Can I add you to review some of these too ? Most of them consists of just moving
> some data. I added rsmith but I think that he is busy with the standard.
Sure thing! do pull out as many bits of cleanup, renaming, refactoring, etc, into separate patches (no worries if you have to also send those for review (not sure if you have commit access/what level of stuff you want to review-after-commit, etc) - still much easier to review in little pieces than all together)
Repository:
rC Clang
https://reviews.llvm.org/D54166
More information about the cfe-commits
mailing list