[PATCH] D54166: [AST] Store the string data in StringLiteral in a trailing array of chars

[Bruno Ricci via Phabricator via cfe-commits]

riccibruno added a comment.

@dblaikie Thanks for looking at this patch !

I have a set of patches shrinking the other statements/expressions.
Can I add you to review some of these too ? Most of them consists of just moving
some data. I added rsmith but I think that he is busy with the standard.



================
Comment at: include/clang/AST/Expr.h:1701
+    for (auto c : getString())
+      if (!isASCII(c))
         return true;
----------------
They are not needed, I just could not resist.
I can factor these changes out of this patch and submit it as an NFC.


Repository:
  rC Clang

https://reviews.llvm.org/D54166