r345833 - Logging: add CMake dependency so libAST can use OSLog analysis.

[Tim Northover via cfe-commits]

Oh bother, I vaguely remember that means I’ll have broken .so builds now?

Either way, I’ve reverted the sequence in r345846. I’ll work on putting the os_log machinery into AST and update the review.

Thanks for looking out!

Tim.

> On 1 Nov 2018, at 16:05, Benjamin Kramer <benny.kra at gmail.com> wrote:
> 
> This doesn't work. AST cannot depend on Analysis because Analysis already depends on AST.
> 
> On Thu, Nov 1, 2018 at 3:24 PM Tim Northover via cfe-commits <cfe-commits at lists.llvm.org <mailto:cfe-commits at lists.llvm.org>> wrote:
> Author: tnorthover
> Date: Thu Nov  1 07:22:20 2018
> New Revision: 345833
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=345833&view=rev <http://llvm.org/viewvc/llvm-project?rev=345833&view=rev>
> Log:
> Logging: add CMake dependency so libAST can use OSLog analysis.
> 
> Should fix bots on platforms with slightly different symbol resolution
> semantics.
> 
> Modified:
>     cfe/trunk/lib/AST/CMakeLists.txt
> 
> Modified: cfe/trunk/lib/AST/CMakeLists.txt
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/CMakeLists.txt?rev=345833&r1=345832&r2=345833&view=diff <http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/CMakeLists.txt?rev=345833&r1=345832&r2=345833&view=diff>
> ==============================================================================
> --- cfe/trunk/lib/AST/CMakeLists.txt (original)
> +++ cfe/trunk/lib/AST/CMakeLists.txt Thu Nov  1 07:22:20 2018
> @@ -1,4 +1,5 @@
>  set(LLVM_LINK_COMPONENTS
> +  Analysis
>    BinaryFormat
>    Support
>    )
> 
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org <mailto:cfe-commits at lists.llvm.org>
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits <http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20181101/2eef854a/attachment.html>