<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Oh bother, I vaguely remember that means I’ll have broken .so builds now?<div class=""><br class=""></div><div class="">Either way, I’ve reverted the sequence in r345846. I’ll work on putting the os_log machinery into AST and update the review.</div><div class=""><br class=""></div><div class="">Thanks for looking out!</div><div class=""><br class=""></div><div class="">Tim.</div><div class=""><br class=""><div class=""><div><blockquote type="cite" class=""><div class="">On 1 Nov 2018, at 16:05, Benjamin Kramer <<a href="mailto:benny.kra@gmail.com" class="">benny.kra@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">This doesn't work. AST cannot depend on Analysis because Analysis already depends on AST.</div><br class=""><div class="gmail_quote"><div dir="ltr" class="">On Thu, Nov 1, 2018 at 3:24 PM Tim Northover via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" class="">cfe-commits@lists.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: tnorthover<br class="">
Date: Thu Nov 1 07:22:20 2018<br class="">
New Revision: 345833<br class="">
<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=345833&view=rev" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project?rev=345833&view=rev</a><br class="">
Log:<br class="">
Logging: add CMake dependency so libAST can use OSLog analysis.<br class="">
<br class="">
Should fix bots on platforms with slightly different symbol resolution<br class="">
semantics.<br class="">
<br class="">
Modified:<br class="">
cfe/trunk/lib/AST/CMakeLists.txt<br class="">
<br class="">
Modified: cfe/trunk/lib/AST/CMakeLists.txt<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/CMakeLists.txt?rev=345833&r1=345832&r2=345833&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/CMakeLists.txt?rev=345833&r1=345832&r2=345833&view=diff</a><br class="">
==============================================================================<br class="">
--- cfe/trunk/lib/AST/CMakeLists.txt (original)<br class="">
+++ cfe/trunk/lib/AST/CMakeLists.txt Thu Nov 1 07:22:20 2018<br class="">
@@ -1,4 +1,5 @@<br class="">
set(LLVM_LINK_COMPONENTS<br class="">
+ Analysis<br class="">
BinaryFormat<br class="">
Support<br class="">
)<br class="">
<br class="">
<br class="">
_______________________________________________<br class="">
cfe-commits mailing list<br class="">
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank" class="">cfe-commits@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br class="">
</blockquote></div>
</div></blockquote></div><br class=""></div></div></body></html>