[PATCH] D53635: [CodeComplete] Expose InBaseClass signal in code completion results.

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 24 05:10:27 PDT 2018


ilya-biryukov added a comment.

And another NIT :-)



================
Comment at: lib/Sema/CodeCompleteConsumer.cpp:548
     OS << "COMPLETION: ";
+    std::vector<std::string> Tags;
     switch (Results[I].Kind) {
----------------
NIT: maybe move Tags into the corresponding case handler?

Would require putting a set of braces around it, but that shouldn't make the code less readable.


Repository:
  rC Clang

https://reviews.llvm.org/D53635





More information about the cfe-commits mailing list