[PATCH] D53635: [CodeComplete] Expose InBaseClass signal in code completion results.
Ilya Biryukov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Oct 24 05:06:04 PDT 2018
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM with a NIT
================
Comment at: lib/Sema/CodeCompleteConsumer.cpp:557
+ if (!Tags.empty())
+ OS << " (" << llvm::join(Tags, ",") << ")";
+ if (CodeCompletionString *CCS = Results[I].CreateCodeCompletionString(
----------------
NIT: Maybe add a space between the items, i.e. join with `", "` as a separator?
Repository:
rC Clang
https://reviews.llvm.org/D53635
More information about the cfe-commits
mailing list