[PATCH] D50539: [VFS] Add property 'fallthrough' that controls fallback to real file system.
Volodymyr Sapsai via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Oct 23 17:59:40 PDT 2018
vsapsai added a comment.
In https://reviews.llvm.org/D50539#1272924, @bruno wrote:
> LGTM with some minor changes.
I was using `//` instead of `///` on purpose. Class `VFSFromYamlDirIterImpl` resides entirely in .cpp file and isn't available outside of it. Comments are supposed to cover implementation details and intention, not class interface. That's why I think those comments shouldn't be consumed by Doxygen. Does it make sense or do you think it would be better to have those comments in Doxygen?
https://reviews.llvm.org/D50539
More information about the cfe-commits
mailing list