[PATCH] D50539: [VFS] Add property 'fallthrough' that controls fallback to real file system.

[Bruno Cardoso Lopes via Phabricator via cfe-commits]

bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.

LGTM with some minor changes.



================
Comment at: llvm/lib/Support/VirtualFileSystem.cpp:1008
+  // Flag telling if we should iterate through ExternalFS or stop at the last
+  // RedirectingDirectoryEntry::iterator.
+  bool IterateExternalFS;
----------------
Please use `///` instead of `//` to get doxygen's auto brief.


================
Comment at: llvm/lib/Support/VirtualFileSystem.cpp:1010
+  bool IterateExternalFS;
+  // Flag telling if we have switched to iterating through ExternalFS.
+  bool IsExternalFSCurrent = false;
----------------
Same here


================
Comment at: llvm/lib/Support/VirtualFileSystem.cpp:1018
+  // ...dispatching between RedirectingDirectoryEntry iteration and ExternalFS
+  // iteration.
+  std::error_code incrementImpl(bool IsFirstTime);
----------------
Same here


================
Comment at: llvm/lib/Support/VirtualFileSystem.cpp:1020
+  std::error_code incrementImpl(bool IsFirstTime);
+  // ...RedirectingDirectoryEntry iteration.
+  std::error_code incrementContent(bool IsFirstTime);
----------------
Same here


================
Comment at: llvm/lib/Support/VirtualFileSystem.cpp:1022
+  std::error_code incrementContent(bool IsFirstTime);
+  // ...ExternalFS iteration.
+  std::error_code incrementExternal();
----------------
Same here


https://reviews.llvm.org/D50539