[PATCH] D52979: [clangd] Add removeFile interface in FileIndex.

[Eric Liu via Phabricator via cfe-commits]

ioeric added inline comments.


================
Comment at: clangd/index/FileIndex.h:78
+  /// Remove all index data associated with the file \p Path.
+  void removeFile(PathRef Path);
+
----------------
hokein wrote:
> ioeric wrote:
> > should we use this somewhere? E.g. when file is closed in ClangdServer?
> Yes, the usage of this method is not included in this patch. 
> 
> We probably use this function in `TUScheduler::remove`, the code path will be like
> 
> `TUScheduler::remove => ParsingCallback::onASTRemove => FileIndex::removeFile`.
> 
> We need to add a similar interface to `ParsingCallback`.
Or maybe in `ClangdServer::removeDocument`?


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D52979