[PATCH] D52979: [clangd] Add removeFile interface in FileIndex.
Haojian Wu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Oct 8 05:14:41 PDT 2018
hokein added inline comments.
================
Comment at: clangd/index/FileIndex.h:78
+ /// Remove all index data associated with the file \p Path.
+ void removeFile(PathRef Path);
+
----------------
ioeric wrote:
> should we use this somewhere? E.g. when file is closed in ClangdServer?
Yes, the usage of this method is not included in this patch.
We probably use this function in `TUScheduler::remove`, the code path will be like
`TUScheduler::remove => ParsingCallback::onASTRemove => FileIndex::removeFile`.
We need to add a similar interface to `ParsingCallback`.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52979
More information about the cfe-commits
mailing list