[PATCH] D53034: [clangd] Remove no-op crash handler, we never set a crash context.

Eric Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 11 04:31:31 PDT 2018


ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.

LGTM

> Of course the question arises: *should* we set one

Agree with your points. If the cleanup is unsafe, it might end up biting us harder in the future.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D53034





More information about the cfe-commits mailing list