[PATCH] D50901: [clang][ubsan] Split Implicit Integer Truncation Sanitizer into unsigned and signed checks
Filipe Cabecinhas via cfe-commits
cfe-commits at lists.llvm.org
Wed Oct 10 16:25:03 PDT 2018
LGTM on the clang side too.
Thank you,
Filipe
On Wed, 10 Oct 2018 at 23:33, Richard Smith - zygoloid via Phabricator <
reviews at reviews.llvm.org> wrote:
> rsmith accepted this revision.
> rsmith added a comment.
> This revision is now accepted and ready to land.
>
> This looks good to me. Sounds like @filcab is intending on doing another
> round of review too, so it'd make sense to double-check there before
> committing.
>
>
>
> ================
> Comment at: docs/UndefinedBehaviorSanitizer.rst:101
> + conversions - when either one, or both of the types are signed.
> Issues caught by this sanitizer are not undefined behavior,
> but are often unintentional.
> ----------------
> this sanitizer -> these sanitizers
>
>
> Repository:
> rC Clang
>
> https://reviews.llvm.org/D50901
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20181011/81563db3/attachment.html>
More information about the cfe-commits
mailing list