[PATCH] D52684: [clang-tidy] NFC refactor lexer-utils slightly to be easier to use

Alexander Kornienko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 5 07:09:45 PDT 2018


alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D52684#1250885, @JonasToth wrote:

> This patch is related to https://reviews.llvm.org/D51949
>
> To isolate variable declarations (split `int * p, v;` up) it is necessary to do a lot of work with source location and requires some forward and backwards lexing. The functions there just use the LangOpts and the SourceManager and don't have a `ASTContext` available, that why I changed this interface.


Makes sense. But then I'd change "to be easier to use" to "to be callable without ASTContext" or something similar in the patch description.

Otherwise LG.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D52684





More information about the cfe-commits mailing list