[PATCH] D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--)

[Alexander Kornienko via Phabricator via cfe-commits]

alexfh added inline comments.


================
Comment at: clang-tidy/tool/clang-tidy-diff.py:123-130
   if args.fix:
     command.append('-fix')
   if args.checks != '':
     command.append('-checks=' + quote + args.checks + quote)
   if args.quiet:
     command.append('-quiet')
   if args.build_path is not None:
----------------
janosimas wrote:
> janosimas wrote:
> > alexfh wrote:
> > > If we make the script leave out the `--` flag, we should stop forwarding these flags and the `extra_arg(_before)?` below. Otherwise it's too confusing (should one place -fix before `--` or after? what about `-warnings-as-errors`?).
> > > 
> > > Please also update the usage example at the top.
> > What about keep the current `--` behavior and add a new flag `-extra-tidy-flags` ? 
> `-extra-tidy-arg` to maintain consistency.
What's the benefit of `-extra-tidy-arg` compared to pass-by arguments?


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D49864