[PATCH] D52872: [clangd] Make binary index format the default, remove dead flag.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 4 03:56:21 PDT 2018


sammccall added inline comments.


================
Comment at: clangd/indexer/IndexerMain.cpp:84
 
-  $ clangd-indexer --executor=all-TUs compile_commands.json > index.yaml
+  $ clangd-indexer --executor=all-TUs compile_commands.json > clangd-index
 
----------------
hokein wrote:
> ilya-biryukov wrote:
> > Maybe we should suggest a default extensions here? E.g. `index.riff`?
> +1
I considered this but am not sure it's useful:
 - means an unneccesary change to workflows if we change the format (happened once!)
 - riff is associated with audio, and I'd expect OSes that care about extensions to draw the wrong conclusion :-)


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D52872





More information about the cfe-commits mailing list