[PATCH] D52872: [clangd] Make binary index format the default, remove dead flag.

[Haojian Wu via Phabricator via cfe-commits]

hokein added inline comments.


================
Comment at: clangd/indexer/IndexerMain.cpp:58
     SymbolCollector::Options Opts;
-    Opts.FallbackDir = AssumedHeaderDir;
     return createStaticIndexingAction(
----------------
If we remove the `assume-header-dir`, we probably remove `FallbackDir` too? I can't remember why we added this option, there is no usage internally either.


================
Comment at: clangd/indexer/IndexerMain.cpp:84
 
-  $ clangd-indexer --executor=all-TUs compile_commands.json > index.yaml
+  $ clangd-indexer --executor=all-TUs compile_commands.json > clangd-index
 
----------------
ilya-biryukov wrote:
> Maybe we should suggest a default extensions here? E.g. `index.riff`?
+1


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D52872