[PATCH] D52751: Allow comments with '#' in dynamic AST Matchers

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

Aside from some naming and style convention nits, LGTM.



================
Comment at: unittests/ASTMatchers/Dynamic/ParserTest.cpp:151
   Sema.parse(" Foo ( Bar ( 17), Baz( \n \"B A,Z\") ) .bind( \"Yo!\") ");
-  for (size_t i = 0, e = Sema.Errors.size(); i != e; ++i) {
-    EXPECT_EQ("", Sema.Errors[i]);
+  for (auto e : Sema.Errors) {
+    EXPECT_EQ("", e);
----------------
`const auto &E` please.


================
Comment at: unittests/ASTMatchers/Dynamic/ParserTest.cpp:188
+  Sema.parse(" Foo() # Bar() ");
+  for (auto e : Sema.Errors) {
+    EXPECT_EQ("", e);
----------------
`const auto &E` please.


Repository:
  rC Clang

https://reviews.llvm.org/D52751