[PATCH] D52751: Allow comments with '#' in dynamic AST Matchers

[Stephen Kelly via Phabricator via cfe-commits]

steveire marked an inline comment as done.
steveire added inline comments.


================
Comment at: unittests/ASTMatchers/Dynamic/ParserTest.cpp:188-190
+  for (size_t i = 0, e = Sema.Errors.size(); i != e; ++i) {
+    EXPECT_EQ("", Sema.Errors[i]);
+  }
----------------
aaron.ballman wrote:
> Why are empty errors created? I would have expected this to be `EXPECT_EQ(0, Sema.Errors.size())`.
> 
> (If this formulation is desired, it should use a range-based for loop.)
This is a copy-paste from elsewhere in the file.

My guess is the author intended the test to print any messages that get recorded while running the unit test (They will differ from the empty string).


Repository:
  rC Clang

https://reviews.llvm.org/D52751