r343573 - [Lex] TokenConcatenation now takes const Preprocessor

Eric Liu via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 2 03:32:42 PDT 2018


Sorry, I messed up my svn rebase somehow and committed and reverted this
again (r343574) when landing r343575.

On Tue, Oct 2, 2018 at 12:30 PM Eric Liu via cfe-commits <
cfe-commits at lists.llvm.org> wrote:

> Author: ioeric
> Date: Tue Oct  2 03:28:50 2018
> New Revision: 343573
>
> URL: http://llvm.org/viewvc/llvm-project?rev=343573&view=rev
> Log:
> [Lex] TokenConcatenation now takes const Preprocessor
>
> Differential Revision: https://reviews.llvm.org/D52502
>
> Modified:
>
> cfe/trunk/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h
>
> Modified:
> cfe/trunk/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h
> URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h?rev=343573&r1=343572&r2=343573&view=diff
>
> ==============================================================================
> ---
> cfe/trunk/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h
> (original)
> +++
> cfe/trunk/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h
> Tue Oct  2 03:28:50 2018
> @@ -79,9 +79,9 @@ class FieldNode {
>  protected:
>    const FieldRegion *FR;
>
> -  /// FieldNodes are never meant to be created on the heap, see
> -  /// FindUninitializedFields::addFieldToUninits().
> -  /* non-virtual */ ~FieldNode() = default;
> +  // TODO: This destructor shouldn't be virtual, but breaks buildbots with
> +  // -Werror -Wnon-virtual-dtor.
> +  virtual ~FieldNode() = default;
>
>  public:
>    FieldNode(const FieldRegion *FR) : FR(FR) {}
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20181002/d66b8a73/attachment.html>


More information about the cfe-commits mailing list