<div dir="ltr"><div class="gmail_quote"><div dir="ltr">Sorry, I messed up my svn rebase somehow and committed and reverted this again (r343574) when landing r343575.<br><br>On Tue, Oct 2, 2018 at 12:30 PM Eric Liu via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: ioeric<br>
Date: Tue Oct  2 03:28:50 2018<br>
New Revision: 343573<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=343573&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=343573&view=rev</a><br>
Log:<br>
[Lex] TokenConcatenation now takes const Preprocessor<br>
<br>
Differential Revision: <a href="https://reviews.llvm.org/D52502" rel="noreferrer" target="_blank">https://reviews.llvm.org/D52502</a><br>
<br>
Modified:<br>
    cfe/trunk/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h<br>
<br>
Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h?rev=343573&r1=343572&r2=343573&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h?rev=343573&r1=343572&r2=343573&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h (original)<br>
+++ cfe/trunk/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h Tue Oct  2 03:28:50 2018<br>
@@ -79,9 +79,9 @@ class FieldNode {<br>
 protected:<br>
   const FieldRegion *FR;<br>
<br>
-  /// FieldNodes are never meant to be created on the heap, see<br>
-  /// FindUninitializedFields::addFieldToUninits().<br>
-  /* non-virtual */ ~FieldNode() = default;<br>
+  // TODO: This destructor shouldn't be virtual, but breaks buildbots with<br>
+  // -Werror -Wnon-virtual-dtor.<br>
+  virtual ~FieldNode() = default;<br>
<br>
 public:<br>
   FieldNode(const FieldRegion *FR) : FR(FR) {}<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div></div>