[PATCH] D52499: [clang-cl] Make /Gs imply default stack probes, not /Gs0 (PR39074)

[Nico Weber via cfe-commits]

Sounds great, thanks!

On Wed, Sep 26, 2018 at 8:33 AM Hans Wennborg via Phabricator via
cfe-commits <cfe-commits at lists.llvm.org> wrote:

> hans added inline comments.
>
>
> ================
> Comment at: include/clang/Driver/CLCompatOptions.td:94
> +def : CLFlag<"Gs">, HelpText<"Use stack probes (default)">,
> +  Alias<mstack_probe_size>, AliasArgs<["4096"]>;
>  def _SLASH_Gs : CLJoined<"Gs">,
> ----------------
> thakis wrote:
> >
> https://docs.microsoft.com/en-us/cpp/build/reference/gs-control-stack-checking-calls?view=vs-2017
> still claims that /Gs is /Gs0 though. Is that just wrong?
> https://bugs.llvm.org/show_bug.cgi?id=39074#c2 suggests it is. Should we
> ask bruce to file a doc bug?
> >
> > And since this flag is supposed to get the default behavior, should it
> be a CLIgnoredFlag instead of duplicating the 4096 somewhat redundantly?
> I've submitted feedback on the document page:
> https://github.com/MicrosoftDocs/cpp-docs/issues/445
>
> By not ignoring it, we enable using /Gs to override a previous e.g. /Gs0
> flag, which I think is the correct thing to do.
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D52499
>
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180926/54820c34/attachment.html>