<div dir="ltr">Sounds great, thanks!</div><br><div class="gmail_quote"><div dir="ltr">On Wed, Sep 26, 2018 at 8:33 AM Hans Wennborg via Phabricator via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">hans added inline comments.<br>
<br>
<br>
================<br>
Comment at: include/clang/Driver/CLCompatOptions.td:94<br>
+def : CLFlag<"Gs">, HelpText<"Use stack probes (default)">,<br>
+  Alias<mstack_probe_size>, AliasArgs<["4096"]>;<br>
 def _SLASH_Gs : CLJoined<"Gs">,<br>
----------------<br>
thakis wrote:<br>
> <a href="https://docs.microsoft.com/en-us/cpp/build/reference/gs-control-stack-checking-calls?view=vs-2017" rel="noreferrer" target="_blank">https://docs.microsoft.com/en-us/cpp/build/reference/gs-control-stack-checking-calls?view=vs-2017</a> still claims that /Gs is /Gs0 though. Is that just wrong? <a href="https://bugs.llvm.org/show_bug.cgi?id=39074#c2" rel="noreferrer" target="_blank">https://bugs.llvm.org/show_bug.cgi?id=39074#c2</a> suggests it is. Should we ask bruce to file a doc bug?<br>
> <br>
> And since this flag is supposed to get the default behavior, should it be a CLIgnoredFlag instead of duplicating the 4096 somewhat redundantly?<br>
I've submitted feedback on the document page: <a href="https://github.com/MicrosoftDocs/cpp-docs/issues/445" rel="noreferrer" target="_blank">https://github.com/MicrosoftDocs/cpp-docs/issues/445</a><br>
<br>
By not ignoring it, we enable using /Gs to override a previous e.g. /Gs0 flag, which I think is the correct thing to do.<br>
<br>
<br>
Repository:<br>
  rL LLVM<br>
<br>
<a href="https://reviews.llvm.org/D52499" rel="noreferrer" target="_blank">https://reviews.llvm.org/D52499</a><br>
<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>