[PATCH] D52222: [clangd] Merge ClangdServer::DynamicIndex into FileIndex. NFC.

[Sam McCall via Phabricator via cfe-commits]

sammccall added inline comments.


================
Comment at: clangd/index/FileIndex.h:121
 std::pair<SymbolSlab, RefSlab>
 indexAST(ASTContext &AST, std::shared_ptr<Preprocessor> PP,
          llvm::ArrayRef<std::string> URISchemes = {});
----------------
ioeric wrote:
> sammccall wrote:
> > indexPreamble would be clearer I think.
> What about `indexHeaderSymbols`? `indexPreamble` seems to require understanding of how preamble is built, but it doesn't seem to matter here if `AST` was built from preamble or not. 
`indexHeaderSymbols` is better, SGTM.

I kind of meant the "conceptual" preamble here - but headers is more accurate (mid-file #includes are possible), and has no risk of confusion with the concrete cacheable preamble.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D52222