[PATCH] D52222: [clangd] Merge ClangdServer::DynamicIndex into FileIndex. NFC.
Eric Liu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Sep 18 03:25:57 PDT 2018
ioeric added inline comments.
================
Comment at: clangd/index/FileIndex.h:121
std::pair<SymbolSlab, RefSlab>
indexAST(ASTContext &AST, std::shared_ptr<Preprocessor> PP,
llvm::ArrayRef<std::string> URISchemes = {});
----------------
sammccall wrote:
> indexPreamble would be clearer I think.
What about `indexHeaderSymbols`? `indexPreamble` seems to require understanding of how preamble is built, but it doesn't seem to matter here if `AST` was built from preamble or not.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52222
More information about the cfe-commits
mailing list