r342053 - [CodeGen] Align rtti and vtable data
Eric Christopher via cfe-commits
cfe-commits at lists.llvm.org
Mon Sep 17 11:45:28 PDT 2018
Thanks for looking Jordan!
On Mon, Sep 17, 2018, 11:16 AM Jordan Rupprecht <rupprecht at google.com>
wrote:
> > Interesting, what kind of failures?
> >
> > If they are causing you problems, of course feel free to revert.
> >
> > Dave
>
> Turns out they are all real issues which running the test under asan
> mode flags as global-buffer-overflow. I'm guessing the over-alignment
> was hiding the bug as reads there would be zero initialized, but now
> they are reading other non-zero data and crashing on that.
>
> So, this patch just exposes some buggy code. Let's not revert it.
> Sorry for the false alarm!
>
> -- Jordan
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180917/fcd8269f/attachment.html>
More information about the cfe-commits
mailing list