r342053 - [CodeGen] Align rtti and vtable data

Jordan Rupprecht via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 17 11:15:34 PDT 2018


> Interesting, what kind of failures?
>
> If they are causing you problems, of course feel free to revert.
>
> Dave

Turns out they are all real issues which running the test under asan
mode flags as global-buffer-overflow. I'm guessing the over-alignment
was hiding the bug as reads there would be zero initialized, but now
they are reading other non-zero data and crashing on that.

So, this patch just exposes some buggy code. Let's not revert it.
Sorry for the false alarm!

-- Jordan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4849 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180917/b7a95535/attachment.bin>


More information about the cfe-commits mailing list