[PATCH] D52008: [analyzer] Handle forwarding reference better in ExprMutationAnalyzer.

Jonas Toth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 14 12:31:27 PDT 2018


JonasToth accepted this revision.
JonasToth added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/Analysis/ExprMutationAnalyzer.cpp:381
+FunctionParmMutationAnalyzer::findMutation(const ParmVarDecl *Parm) {
+  const auto Memoized = Results.find(Parm);
+  if (Memoized != Results.end())
----------------
shuaiwang wrote:
> JonasToth wrote:
> > Please spell out the type here
> This type is a bit cumbersome to spell out as it's an iterator. I feel it's fine to keep it auto.
Oh true, iterator can be `auto`ed I would say ;)


Repository:
  rC Clang

https://reviews.llvm.org/D52008





More information about the cfe-commits mailing list