[PATCH] D52008: [analyzer] Handle forwarding reference better in ExprMutationAnalyzer.
Shuai Wang via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Sep 14 11:31:35 PDT 2018
shuaiwang added a comment.
In https://reviews.llvm.org/D52008#1234828, @JonasToth wrote:
> The `std::move` as cast is a follow up patch?
Yes I'll send a follow up patch.
================
Comment at: lib/Analysis/ExprMutationAnalyzer.cpp:381
+FunctionParmMutationAnalyzer::findMutation(const ParmVarDecl *Parm) {
+ const auto Memoized = Results.find(Parm);
+ if (Memoized != Results.end())
----------------
JonasToth wrote:
> Please spell out the type here
This type is a bit cumbersome to spell out as it's an iterator. I feel it's fine to keep it auto.
Repository:
rC Clang
https://reviews.llvm.org/D52008
More information about the cfe-commits
mailing list