[PATCH] D51508: Export public functions implemented in assembly on Windows.

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 31 11:09:59 PDT 2018

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.


Comment at: src/assembly.h:76-78
+  .section .drectve,"yn" SEPARATOR                        \
+  .ascii "-export:", #name, "\0" SEPARATOR                \
+  .text
cdavis5x wrote:
> rnk wrote:
> > Maybe .pushsection / .popsection is better than assuming you were in .text.
> I initially wanted to do that, but those directives aren't supported by COFF. Neither, by the way, is `.previous`. Perhaps this needs to be fixed in LLVM.
Huh, I guess neither does gas. .text is fine then. I'll file a bug to implement those directives for COFF. They're pretty handy, especially for an object file format that uses comdat sections so frequently.

  rUNW libunwind


More information about the cfe-commits mailing list