[PATCH] D51508: Export public functions implemented in assembly on Windows.

[Charles Davis via Phabricator via cfe-commits]

cdavis5x added inline comments.


================
Comment at: src/assembly.h:76-78
+  .section .drectve,"yn" SEPARATOR                        \
+  .ascii "-export:", #name, "\0" SEPARATOR                \
+  .text
----------------
rnk wrote:
> Maybe .pushsection / .popsection is better than assuming you were in .text.
I initially wanted to do that, but those directives aren't supported by COFF. Neither, by the way, is `.previous`. Perhaps this needs to be fixed in LLVM.


Repository:
  rUNW libunwind

https://reviews.llvm.org/D51508