[PATCH] D51422: [clangd] Factor out the data-swapping functionality from MemIndex/DexIndex.

Eric Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 31 06:33:35 PDT 2018

ioeric added inline comments.

Comment at: clangd/index/dex/DexIndex.h:42
+  // All symbols must outlive this index.
+  template <typename Range> DexIndex(Range &&Symbols) {
+    for (auto &&Sym : Symbols)
Why is this constructor needed? I think this could restrict the flexibility of DexIndex initialization, in case we need to pass in extra parameters here.

  rCTE Clang Tools Extra


More information about the cfe-commits mailing list