[PATCH] D51422: [clangd] Factor out the data-swapping functionality from MemIndex/DexIndex.

Kirill Bobyrev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 31 03:02:42 PDT 2018

kbobyrev added inline comments.

Comment at: clangd/index/Index.h:416
+  // until the call returns (even if reset() is called).
+  bool fuzzyFind(const FuzzyFindRequest &,
+                 llvm::function_ref<void(const Symbol &)>) const override;
Do we want these functions to be `final`? Since `SwapIndex` is a wrapper around an immutable index structure, I believe it would be unlikely that anything would derive from it.

  rCTE Clang Tools Extra


More information about the cfe-commits mailing list