[PATCH] D51434: [HIP] Add -fvisibility hidden option to clang

Yaxun Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 30 07:37:31 PDT 2018

yaxunl added inline comments.

Comment at: lib/Driver/ToolChains/HIP.cpp:256
+    CC1Args.append({"-fvisibility", "hidden"});
arsenm wrote:
> We should probably start subclassing the HIP toolchain from AMDGPU and share more of this
I'd like to defer the refactoring of HIP and AMDGPU toolchain to another patch. There are stuff in HIP toolchain which should go to AMDGPU toolchain. We need to sort out the relation between HIP and AMDGPU toolchain in that patch.


More information about the cfe-commits mailing list