arsenm added inline comments. ================ Comment at: lib/Driver/ToolChains/HIP.cpp:256 + CC1Args.append({"-fvisibility", "hidden"}); } ---------------- We should probably start subclassing the HIP toolchain from AMDGPU and share more of this https://reviews.llvm.org/D51434