[PATCH] D51382: [MinGW] Don't mark external variables as DSO local

Martin Storsjö via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 29 08:52:13 PDT 2018

mstorsjo added inline comments.

Comment at: test/CodeGen/dso-local-executable.c:14
+// MINGW-DAG: @bar = external global i32
+// MINGW-DAG: @weak_bar = extern_weak global i32
+// MINGW-DAG: declare dso_local void @foo()
rnk wrote:
> I take it that was a side effect of the isDeclarationForLinker change? I think that's correct.
Yes, it changed due to that. It probably won't hurt at least.


More information about the cfe-commits mailing list