[PATCH] D51382: [MinGW] Don't mark external variables as DSO local

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 29 08:39:26 PDT 2018


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: test/CodeGen/dso-local-executable.c:14
+// MINGW-DAG: @bar = external global i32
+// MINGW-DAG: @weak_bar = extern_weak global i32
+// MINGW-DAG: declare dso_local void @foo()
----------------
I take it that was a side effect of the isDeclarationForLinker change? I think that's correct.


https://reviews.llvm.org/D51382





More information about the cfe-commits mailing list